Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stats: limit the length of sample values (#7931) #7982

Merged
merged 3 commits into from Oct 23, 2018

Conversation

@lamxTyler
Copy link
Member

commented Oct 22, 2018

What problem does this PR solve?

Cherry-pick #7931

What is changed and how it works?

Cherry-pick #7931

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

  • None

Related changes

  • None
@iamxy

This comment has been minimized.

Copy link
Member

commented Oct 22, 2018

/run-all-tests

3 similar comments
@iamxy

This comment has been minimized.

Copy link
Member

commented Oct 22, 2018

/run-all-tests

@iamxy

This comment has been minimized.

Copy link
Member

commented Oct 22, 2018

/run-all-tests

@iamxy

This comment has been minimized.

Copy link
Member

commented Oct 22, 2018

/run-all-tests

@zz-jason

This comment has been minimized.

Copy link
Member

commented Oct 22, 2018

LGTM

@zz-jason

This comment has been minimized.

Copy link
Member

commented Oct 22, 2018

@lamxTyler should we also cherry pick it to release-2.0?

@winoros
Copy link
Member

left a comment

lgtm

@zz-jason

This comment has been minimized.

Copy link
Member

commented Oct 23, 2018

/run-all-tests

@zz-jason

This comment has been minimized.

Copy link
Member

commented Oct 23, 2018

/run-integration-common-test
/run-integration-compatibility-test
/run-integration-ddl-test

@lamxTyler

This comment has been minimized.

Copy link
Member Author

commented Oct 23, 2018

@zz-jason Yes.

@lamxTyler

This comment has been minimized.

Copy link
Member Author

commented Oct 23, 2018

/run-integration-common-test
/run-integration-compatibility-test
/run-integration-ddl-test

@zz-jason

This comment has been minimized.

Copy link
Member

commented Oct 23, 2018

/run-integration-common-test tikv=release-2.1 pd=release-2.1
/run-integration-compatibility-test tikv=release-2.1 pd=release-2.1
/run-integration-ddl-test tikv=release-2.1 pd=release-2.1

@zz-jason

This comment has been minimized.

Copy link
Member

commented Oct 23, 2018

/run-integration-common-test tikv=release-2.1 pd=release-2.1

@zz-jason zz-jason merged commit c2c7d3d into pingcap:release-2.1 Oct 23, 2018

11 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tidb/mybatis-test Jenkins job succeeded.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job succeeded.
Details
jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@lamxTyler lamxTyler deleted the lamxTyler:sample-length branch Oct 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.