Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: fix bug which Float type is not effective in AddDate & SubDate… #8009

Merged
merged 3 commits into from Oct 23, 2018

Conversation

@lzmhhh123
Copy link
Member

commented Oct 23, 2018

What problem does this PR solve?

cherry-pick #7840

@zz-jason

This comment has been minimized.

Copy link
Member

commented Oct 23, 2018

LGTM

@zz-jason

This comment has been minimized.

Copy link
Member

commented Oct 23, 2018

/run-all-tests tikv=release-2.1 pd=release-2.1

@zz-jason

This comment has been minimized.

Copy link
Member

commented Oct 23, 2018

@XuHuaiyu
Copy link
Contributor

left a comment

LGTM

@zz-jason zz-jason added status/LGT2 and removed status/LGT1 labels Oct 23, 2018

ngaut and others added 2 commits Oct 23, 2018

@zz-jason zz-jason merged commit 6cb942b into pingcap:release-2.1 Oct 23, 2018

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@lzmhhh123 lzmhhh123 deleted the lzmhhh123:release-2.1f branch Nov 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.