Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pkg/errors && add pump client in vendor #8093

Merged
merged 3 commits into from Oct 29, 2018

Conversation

@WangXiangUSTC
Copy link
Member

WangXiangUSTC commented Oct 29, 2018

What problem does this PR solve?

add some function to adjust juju/errors in pkg/errors, so update this pkg
add pump client in vendor, I will use pump client to send binlog next pr.
same with pr #8051

What is changed and how it works?

dep ensure -update github.com/pkg/errors
dep ensure -add github.com/pingcap/tidb-tools/tidb-binlog/pump_client@5db58e3b7e6613456551c40d011806a346b2f44a
sh hack/clean_vendor.sh
@zz-jason

This comment has been minimized.

Copy link
Member

zz-jason commented Oct 29, 2018

/run-all-tests

@WangXiangUSTC

This comment has been minimized.

Copy link
Member Author

WangXiangUSTC commented Oct 29, 2018

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@zz-jason

This comment has been minimized.

Copy link
Member

zz-jason commented Oct 29, 2018

LGTM

@zz-jason

This comment has been minimized.

Copy link
Member

zz-jason commented Oct 29, 2018

Copy link
Member

lamxTyler left a comment

LGTM

@lamxTyler lamxTyler added status/LGT2 and removed status/LGT1 labels Oct 29, 2018
@jackysp jackysp merged commit ebebc2a into pingcap:release-2.1 Oct 29, 2018
11 checks passed
11 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tidb/mybatis-test Jenkins job succeeded.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job succeeded.
Details
jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
@WangXiangUSTC WangXiangUSTC deleted the WangXiangUSTC:update_vendor branch Nov 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.