Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plan: try point get when plan cache is enabled #8108

Merged
merged 5 commits into from Oct 31, 2018

Conversation

@eurekaka
Copy link
Contributor

commented Oct 30, 2018

What problem does this PR solve?

Fix #8095

What is changed and how it works?

Enhance rebuildRange to support updating PointGetPlan. Specifically, use parameter values to update Handle/IndexValues of PointGetPlan. DELETE/UPDATE is not cacheable yet, so it should be safe.

Check List

Tests

  • Unit test

Side effects

  • Increased code complexity

Related changes

N/A

eurekaka added 3 commits Oct 26, 2018
enable const = col for point get
@eurekaka eurekaka changed the title plan: try point get when plan cache is enabled [WIP] plan: try point get when plan cache is enabled Oct 30, 2018
@eurekaka

This comment has been minimized.

Copy link
Contributor Author

commented Oct 30, 2018

/run-all-tests

@eurekaka eurekaka changed the title [WIP] plan: try point get when plan cache is enabled plan: try point get when plan cache is enabled Oct 30, 2018
Copy link
Member

left a comment

LGTM

@zz-jason

This comment has been minimized.

Copy link
Member

commented Oct 31, 2018

@winoros

This comment has been minimized.

Copy link
Member

commented Oct 31, 2018

Yeah BTW, you can paste a sysbench result with this branch.

@eurekaka

This comment has been minimized.

Copy link
Contributor Author

commented Oct 31, 2018

sysbench result using oltp_point_select.lua when plan cache is enabled:

qps
latency
improve

Copy link
Member

left a comment

lgtm

@winoros winoros merged commit 59c4db7 into pingcap:master Oct 31, 2018
4 checks passed
4 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
@eurekaka eurekaka deleted the eurekaka:point_get_plan_cache branch Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.