Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: handle INTERVAL HOUR for date arithmetic functions #8146

Merged
merged 3 commits into from Nov 2, 2018

Conversation

imiskolee
Copy link
Contributor

more details: #8077

What problem does this PR solve?

fix bug: #8077

What is changed and how it works?

Just apply unit:day special logic to unit:hour.

Check List

Tests

  • Unit test
  • Integration test

Code changes

Side effects

Related changes

@sre-bot
Copy link
Contributor

sre-bot commented Nov 2, 2018

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@imiskolee
Copy link
Contributor Author

@ngaut closed that old PR, and move on it.

@ngaut
Copy link
Member

ngaut commented Nov 2, 2018

LGTM

@zz-jason zz-jason changed the title apply unit:day special logic on unit:hour for INTERVAL segment expression: handle INTERVAL HOUR for date arithmetic functions Nov 2, 2018
@zz-jason zz-jason added contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2. type/bug-fix This PR fixes a bug. component/expression labels Nov 2, 2018
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason
Copy link
Member

zz-jason commented Nov 2, 2018

/run-all-tests

@ngaut ngaut merged commit 31f5abd into pingcap:master Nov 2, 2018
@imiskolee imiskolee deleted the fix-interval-unit-hour-format branch November 3, 2018 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2. type/bug-fix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants