Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: support for "admin show next_row_id" #8242

Merged
merged 8 commits into from Nov 9, 2018
Merged

Conversation

@zimulala
Copy link
Member

zimulala commented Nov 8, 2018

What problem does this PR solve?

Before this PR, we only can get the table's auto-increment ID. Now we want to know the next global row ID.

What is changed and how it works?

Support for "admin show next_row_id".

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
@zimulala

This comment has been minimized.

Copy link
Member Author

zimulala commented Nov 8, 2018

After we merge the PR of #7965, I will handle conflicts with the file of go.mod.

@zimulala

This comment has been minimized.

Copy link
Member Author

zimulala commented Nov 8, 2018

Copy link
Member

crazycs520 left a comment

Reset LGTM

planner/core/planbuilder.go Outdated Show resolved Hide resolved
planner/core/planbuilder.go Outdated Show resolved Hide resolved
@zimulala zimulala removed the status/DNM label Nov 9, 2018
planner/core/planbuilder.go Outdated Show resolved Hide resolved
planner/core/planbuilder.go Outdated Show resolved Hide resolved
@zimulala

This comment has been minimized.

Copy link
Member Author

zimulala commented Nov 9, 2018

Copy link
Member

zz-jason left a comment

LGTM

@zz-jason zz-jason added the status/LGT1 label Nov 9, 2018
Copy link
Member

crazycs520 left a comment

LGTM

@jackysp
jackysp approved these changes Nov 9, 2018
Copy link
Member

jackysp left a comment

LGTM

@jackysp

This comment has been minimized.

Copy link
Member

jackysp commented Nov 9, 2018

/run-all-tests

@zz-jason zz-jason merged commit f3a9745 into pingcap:master Nov 9, 2018
4 checks passed
4 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.