Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ast, plan: return error when the arg of VALUES() function is not a column (#7817) #8404

Merged
merged 4 commits into from Nov 22, 2018

Conversation

Projects
None yet
4 participants
@XuHuaiyu
Copy link
Contributor

commented Nov 22, 2018

cherry-pick #7817


This change is Reviewable

@XuHuaiyu

This comment has been minimized.

Copy link
Contributor Author

commented Nov 22, 2018

/run-all-test tidb-test=release-2.0 pd=release-2.0 tikv=release-2.0

@@ -1644,6 +1644,8 @@ func (s *testPlanSuite) TestNameResolver(c *C) {
{"select a from t group by t11.c1", "[planner:1054]Unknown column 't11.c1' in 'group statement'"},
{"delete a from (select * from t ) as a, t", "[planner:1288]The target table a of the DELETE is not updatable"},
{"delete b from (select * from t ) as a, t", "[planner:1109]Unknown table 'b' in MULTI DELETE"},
{"select '' as fakeCol from t group by values(fakeCol)", "[planner:1054]Unknown column '' in 'VALUES() function'"},
{"update t, (select * from t) as b set b.a = t.a", "[planner:1288]The target table b of the UPDATE is not updatable"},

This comment has been minimized.

Copy link
@eurekaka

eurekaka Nov 22, 2018

Contributor

This line is irrelevant?

This comment has been minimized.

Copy link
@XuHuaiyu

XuHuaiyu Nov 22, 2018

Author Contributor

Yes, removed now.

@lamxTyler
Copy link
Member

left a comment

LGTM

@zz-jason
Copy link
Member

left a comment

LGTM

@zz-jason

This comment has been minimized.

Copy link
Member

commented Nov 22, 2018

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

@zz-jason zz-jason merged commit 1665ff9 into pingcap:release-2.0 Nov 22, 2018

11 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tidb/mybatis-test Jenkins job succeeded.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job succeeded.
Details
jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@XuHuaiyu XuHuaiyu deleted the XuHuaiyu:cherry-pick-values-2.0 branch Apr 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.