Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: add check when create table with foreign key. (#7885) #8410

Merged
merged 2 commits into from Nov 23, 2018

Conversation

Projects
None yet
3 participants
@crazycs520
Copy link
Contributor

crazycs520 commented Nov 22, 2018

What problem does this PR solve?

cherry-pick from #7885.


This change is Reviewable

ddl: add check when create table with foreign key. (#7885)
* ddl: add check when create table with foreign key
@crazycs520

This comment has been minimized.

Copy link
Contributor Author

crazycs520 commented Nov 22, 2018

/run-all-tests tidb-test=release-2.0 pd=release-2.0 tikv=release-2.0

1 similar comment
@crazycs520

This comment has been minimized.

Copy link
Contributor Author

crazycs520 commented Nov 22, 2018

/run-all-tests tidb-test=release-2.0 pd=release-2.0 tikv=release-2.0

@crazycs520

This comment has been minimized.

Copy link
Contributor Author

crazycs520 commented Nov 23, 2018

@crazycs520 crazycs520 force-pushed the crazycs520:check-foreign-2.0 branch from d995158 to 8293831 Nov 23, 2018

@crazycs520

This comment has been minimized.

Copy link
Contributor Author

crazycs520 commented Nov 23, 2018

/run-all-tests tidb-test=release-2.0 pd=release-2.0 tikv=release-2.0

@crazycs520

This comment has been minimized.

Copy link
Contributor Author

crazycs520 commented Nov 23, 2018

/run-all-tests tidb-test=release-2.0 pd=release-2.0 tikv=release-2.0

@crazycs520 crazycs520 changed the title ddl: check foreign key ddl: check foreign key when create table. Nov 23, 2018

@zz-jason zz-jason changed the title ddl: check foreign key when create table. ddl: add check when create table with foreign key. (#7885) Nov 23, 2018

@zz-jason

This comment has been minimized.

Copy link
Member

zz-jason commented Nov 23, 2018

LGTM

@winkyao
Copy link
Member

winkyao left a comment

LGTM

@winkyao winkyao merged commit 3f03b30 into pingcap:release-2.0 Nov 23, 2018

11 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tidb/mybatis-test Jenkins job succeeded.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job succeeded.
Details
jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.