New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner/core, expression: don't pushdown filters contains set or get var #8412

Merged
merged 5 commits into from Nov 26, 2018

Conversation

Projects
None yet
3 participants
@zz-jason
Member

zz-jason commented Nov 22, 2018

What problem does this PR solve?

For filters contain SetVar or GetVar, donot push it down. Make it possible to use user variables to simulate the window function.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Related changes

  • Need to cherry-pick to the release branch

This change is Reviewable

@zz-jason

This comment has been minimized.

Member

zz-jason commented Nov 22, 2018

/run-all-tests

@zz-jason

This comment has been minimized.

Member

zz-jason commented Nov 26, 2018

@eurekaka comments addressed, PTAL

@eurekaka

LGTM

@eurekaka eurekaka added status/LGT2 and removed status/LGT1 labels Nov 26, 2018

@zz-jason

This comment has been minimized.

Member

zz-jason commented Nov 26, 2018

/run-all-tests

@zz-jason

This comment has been minimized.

Member

zz-jason commented Nov 26, 2018

/run-common-test tidb-test=pr/667
/run-integration-common-test tidb-test=pr/667

@zz-jason zz-jason merged commit 4149000 into pingcap:master Nov 26, 2018

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@zz-jason zz-jason deleted the zz-jason:dev/uservar-pushdown branch Nov 26, 2018

zz-jason added a commit to zz-jason/tidb that referenced this pull request Nov 26, 2018

zz-jason added a commit that referenced this pull request Nov 26, 2018

zz-jason added a commit to zz-jason/tidb that referenced this pull request Nov 26, 2018

zz-jason added a commit that referenced this pull request Nov 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment