Skip to content

/tidb

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: add check when add foreign key. (#8050) #8421

Merged
merged 4 commits into from Nov 24, 2018

Conversation

@crazycs520
Copy link
Contributor

crazycs520 commented Nov 23, 2018 •
edited by c4pt0r

What problem does this PR solve?

merge #8410 first.
cherry-pick #8050

This change is Reviewable
crazycs520 added 2 commits Oct 17, 2018
@crazycs520
ddl: add check when create table with foreign key. (#7885)
Loading status checks…
8293831 
* ddl: add check when create table with foreign key
@crazycs520
ddl: add check when add foreign key. (#8050)
Loading status checks…
e0cd02d
@crazycs520 crazycs520 changed the title Check add foreign 2.0 ddl: check foreign key when add foreign key. Nov 23, 2018
@zz-jason zz-jason changed the title ddl: check foreign key when add foreign key. ddl: add check when add foreign key. (#8050) Nov 23, 2018
@winkyao
winkyao reviewed Nov 23, 2018
View changes
Copy link
Member

winkyao left a comment

LGTM, please fix conflicts
@crazycs520
Merge branch 'release-2.0' of https://github.com/pingcap/tidb into ch…
Loading status checks…
25cec66 
…eck-add-foreign-2.0
@zz-jason
zz-jason approved these changes Nov 24, 2018
View changes
Copy link
Member

zz-jason left a comment

LGTM
@zz-jason

This comment has been minimized.

Sign in to view
Copy link
Member

zz-jason commented Nov 24, 2018

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0
@crazycs520

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

crazycs520 commented Nov 24, 2018

/run-sqllogic-test tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0
2 similar comments
@crazycs520

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

crazycs520 commented Nov 24, 2018

/run-sqllogic-test tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0
@crazycs520

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

crazycs520 commented Nov 24, 2018

/run-sqllogic-test tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0
@crazycs520

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

crazycs520 commented Nov 24, 2018

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0
@iamxy

This comment has been minimized.

Sign in to view
Copy link
Member

iamxy commented Nov 24, 2018

/run-sqllogic-test tidb-test=release-2.0
@crazycs520
Merge branch 'release-2.0' into check-add-foreign-2.0
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8c37866
@zz-jason zz-jason merged commit 420d8da into pingcap:release-2.0 Nov 24, 2018
4 checks passed
4 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winkyao winkyao

@zz-jason zz-jason

Assignees
No one assigned
Labels
component/DDL-need-LGT3 status/LGT2 status/all tests passed type/2.0 cherry-pick
Projects
None yet
Milestone
No milestone
4 participants
@crazycs520 @zz-jason @iamxy @winkyao
You can’t perform that action at this time.