New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: integrate trace format view tool to the web UI #8430

Merged
merged 5 commits into from Nov 26, 2018

Conversation

Projects
None yet
4 participants
@tiancaiamao
Contributor

tiancaiamao commented Nov 23, 2018

What problem does this PR solve?

trace output a json format data, now it can be visualized in
http://localhost:10080/web/trace

What is changed and how it works?

trace

Ref #8357

Check List

Tests

  • Manual test (add detailed scripts or steps below)

This change is Reviewable

tiancaiamao added some commits Nov 23, 2018

server: integrate trace format view tool to the web UI
trace output a json format data, now it can be visualized in
http://localhost:10080/web/trace
@tiancaiamao

This comment has been minimized.

Contributor

tiancaiamao commented Nov 24, 2018

}
router.HandleFunc("/web/trace", traceapp.HandleTiDB)
sr := router.PathPrefix("/web/trace/").Subrouter()
if _, err := traceapp.New(traceapp.NewRouter(sr), baseURL); err == nil {

This comment has been minimized.

@jackysp

jackysp Nov 26, 2018

Member

Should be err != nil?

@lysu

This comment has been minimized.

Member

lysu commented Nov 26, 2018

@tiancaiamao please also fix http://127.0.0.1:10080/ 's content

tiancaiamao added some commits Nov 26, 2018

@tiancaiamao

This comment has been minimized.

Contributor

tiancaiamao commented Nov 26, 2018

Done @lysu @jackysp
/run-all-tests

@lysu

lysu approved these changes Nov 26, 2018

LGTM

@tiancaiamao

This comment has been minimized.

Contributor

tiancaiamao commented Nov 26, 2018

Wait for @zhexuany to fix CI

@zhexuany

This comment has been minimized.

Member

zhexuany commented Nov 26, 2018

/run-all-tests

@zhexuany

This comment has been minimized.

Member

zhexuany commented Nov 26, 2018

/run-integration-ddl-test tidb-test=pr/668

/run-integration-common-test tidb-test=pr/668

/run-common-test tidb-test=pr/668

@tiancaiamao tiancaiamao merged commit 18503e4 into pingcap:master Nov 26, 2018

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@tiancaiamao tiancaiamao deleted the tiancaiamao:trace-web-ui branch Nov 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment