Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser/opcode: fix format function for mod opcode (#7455) #8431

Merged
merged 2 commits into from Nov 26, 2018

Conversation

Projects
None yet
3 participants
@tiancaiamao
Copy link
Contributor

tiancaiamao commented Nov 24, 2018

Cherry-pick from #7455 to release-2.0
This is a parser bug, but it may cause trouble for DDL

@winkyao @lysu @hicqu


This change is Reviewable

@tiancaiamao

This comment has been minimized.

Copy link
Contributor Author

tiancaiamao commented Nov 24, 2018

/run-all-tests tidb-test=release-2.0 pd=release-2.0 tikv=release-2.0

@zz-jason

This comment has been minimized.

Copy link
Member

zz-jason commented Nov 26, 2018

LGTM

@zz-jason

This comment has been minimized.

Copy link
Member

zz-jason commented Nov 26, 2018

/run-all-tests tidb-test=release-2.0 pd=release-2.0 tikv=release-2.0

@zz-jason

This comment has been minimized.

Copy link
Member

zz-jason commented Nov 26, 2018

@jackysp
Copy link
Member

jackysp left a comment

LGTM

@jackysp jackysp merged commit e6c84be into pingcap:release-2.0 Nov 26, 2018

11 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tidb/mybatis-test Jenkins job succeeded.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job succeeded.
Details
jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.