Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner/core, expression: don't pushdown filters contains set or get var (#8412) #8454

Merged
merged 6 commits into from Nov 29, 2018

Conversation

Projects
None yet
4 participants
@zz-jason
Copy link
Member

commented Nov 26, 2018

cherry pick #8412 to release-2.0


This change is Reviewable

@eurekaka
Copy link
Contributor

left a comment

LGTM

@XuHuaiyu
Copy link
Contributor

left a comment

LGTM

@XuHuaiyu

This comment has been minimized.

Copy link
Contributor

commented Nov 26, 2018

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

@zz-jason zz-jason added status/LGT2 and removed status/LGT1 labels Nov 26, 2018

@zz-jason

This comment has been minimized.

Copy link
Member Author

commented Nov 27, 2018

/run-integration-common-test tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0
/run-common-test tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

@zz-jason

This comment has been minimized.

Copy link
Member Author

commented Nov 27, 2018

weird, the test is passed in my local machine..

@zz-jason

This comment has been minimized.

Copy link
Member Author

commented Nov 27, 2018

/run-integration-common-test tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0
/run-common-test tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

@zz-jason

This comment has been minimized.

Copy link
Member Author

commented Nov 28, 2018

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

@zz-jason

This comment has been minimized.

Copy link
Member Author

commented Nov 28, 2018

/run-unit-test

@ngaut

ngaut approved these changes Nov 29, 2018

@zz-jason zz-jason merged commit a9c77f1 into pingcap:release-2.0 Nov 29, 2018

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@zz-jason zz-jason deleted the zz-jason:cherrypick/2.0-uservar branch Nov 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.