New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix overflow error message of `update` #8457

Merged
merged 2 commits into from Nov 27, 2018

Conversation

Projects
None yet
6 participants
@exialin
Contributor

exialin commented Nov 26, 2018

What problem does this PR solve?

Fix #8119 to make TiDB consistent with MySQL when updated value overflows.

However, the row number showed by the error message is trivial, as discussed in that issue.

What is changed and how it works?

Check error type in handleErr.

Check List

Tests

  • Unit test

This change is Reviewable

@sre-bot

This comment has been minimized.

sre-bot commented Nov 26, 2018

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@CLAassistant

This comment has been minimized.

CLAassistant commented Nov 26, 2018

CLA assistant check
All committers have signed the CLA.

@XuHuaiyu

This comment has been minimized.

Contributor

XuHuaiyu commented Nov 26, 2018

@exialin Thanks for your contribution.
LGTM

@XuHuaiyu

This comment has been minimized.

Contributor

XuHuaiyu commented Nov 26, 2018

/run-all-tests

@zz-jason

This comment has been minimized.

Member

zz-jason commented Nov 26, 2018

@XuHuaiyu PTAL

@zhouqiang-cl

This comment has been minimized.

Member

zhouqiang-cl commented Nov 26, 2018

/run-all-tests

@zz-jason zz-jason merged commit 0d005a0 into pingcap:master Nov 27, 2018

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
@zz-jason

This comment has been minimized.

Member

zz-jason commented Nov 27, 2018

@exialin could you please cherry-pick this commit to the release-2.1 and release-2.0 branch?

@exialin

This comment has been minimized.

Contributor

exialin commented Nov 27, 2018

@zz-jason Sure. But release-2.0 does not have update.go, should I still apply the change to this branch?

@exialin

This comment has been minimized.

Contributor

exialin commented Nov 28, 2018

@zz-jason If we want to apply this fix to release-2.0, something of #8045 needs to be picked too. So maybe it would be better to leave it as it is?

@zz-jason

This comment has been minimized.

Member

zz-jason commented Nov 28, 2018

@exialin exialin deleted the exialin:fix-update-error-msg branch Nov 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment