Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stats: fix panic when dumping stats (#8448) #8464

Merged
merged 5 commits into from Nov 28, 2018

Conversation

Projects
None yet
3 participants
@lamxTyler
Copy link
Member

lamxTyler commented Nov 27, 2018

Cherry pick #8448


This change is Reviewable

@zz-jason

This comment has been minimized.

Copy link
Member

zz-jason commented Nov 27, 2018

@lamxTyler CI failed.

@zz-jason

This comment has been minimized.

Copy link
Member

zz-jason commented Nov 27, 2018

LGTM

@zz-jason

This comment has been minimized.

Copy link
Member

zz-jason commented Nov 27, 2018

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

@zz-jason

This comment has been minimized.

Copy link
Member

zz-jason commented Nov 27, 2018

@zz-jason
Copy link
Member

zz-jason left a comment

Reviewed 2 of 3 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

my mistake ..

@eurekaka
Copy link
Contributor

eurekaka left a comment

LGTM

@eurekaka eurekaka added status/LGT2 and removed status/LGT1 labels Nov 28, 2018

eurekaka and others added some commits Nov 28, 2018

@zz-jason
Copy link
Member

zz-jason left a comment

:lgtm:

Reviewed 2 of 2 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@zz-jason zz-jason merged commit ced80e5 into pingcap:release-2.0 Nov 28, 2018

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
code-review/reviewable 3 files reviewed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.