New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table, executor: set a real enum as the default enum value #8469

Merged
merged 3 commits into from Nov 27, 2018

Conversation

Projects
None yet
4 participants
@jackysp
Member

jackysp commented Nov 27, 2018

What problem does this PR solve?

When getting a default enum value from nil, TiDB will return a string type datum, which will cause panic when reading the inserted value.

What is changed and how it works?

Set an enum value as the default.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

  • Increased code complexity

Related changes

  • Need to cherry-pick to the release branch

This change is Reviewable

@jackysp jackysp requested review from lysu and crazycs520 Nov 27, 2018

@lysu

lysu approved these changes Nov 27, 2018 edited

LGTM and need cherry-pick to 2.1/2.0?

@lysu lysu added the status/LGT2 label Nov 27, 2018

@zz-jason

This comment has been minimized.

Member

zz-jason commented Nov 27, 2018

/run-all-tests

@jackysp jackysp merged commit e2e8d67 into pingcap:master Nov 27, 2018

11 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tidb/mybatis-test Jenkins job succeeded.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job succeeded.
Details
jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

jackysp added a commit to jackysp/tidb that referenced this pull request Nov 27, 2018

jackysp added a commit to jackysp/tidb that referenced this pull request Nov 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment