Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: privilege check ANALYZE TABLE stmt #8486

Merged
merged 6 commits into from Dec 28, 2018

Conversation

Projects
None yet
5 participants
@morgo
Copy link
Member

morgo commented Nov 28, 2018

What problem does this PR solve?

Fixes #5277

What is changed and how it works?

Check for both SELECT and INSERT privilege, per MySQL compatibility.

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Code changes

  • Minimal

Side effects

  • Breaking backward compatibility (for broken apps)

Related changes

  • Need to be included in the release note

This change is Reviewable

@morgo

This comment has been minimized.

Copy link
Member Author

morgo commented Nov 28, 2018

/run-all-tests

Show resolved Hide resolved planner/core/planbuilder.go Outdated
Show resolved Hide resolved planner/core/planbuilder.go Outdated

morgo added some commits Dec 27, 2018

@morgo

This comment has been minimized.

Copy link
Member Author

morgo commented Dec 27, 2018

Thank you for the feedback, I've incorporated the changes.. and it looks a lot cleaner.

One thing I don't like about visitInfo is the MySQL error codes don't match, but this is an existing problem. I have created #8838 to address.

PTAL @eurekaka, @lamxTyler

@lamxTyler
Copy link
Member

lamxTyler left a comment

LGTM

@shenli

This comment has been minimized.

Copy link
Member

shenli commented Dec 27, 2018

@shenli

This comment has been minimized.

Copy link
Member

shenli commented Dec 27, 2018

/run-all-tests

@eurekaka
Copy link
Contributor

eurekaka left a comment

LGTM

@eurekaka eurekaka merged commit fe01b16 into pingcap:master Dec 28, 2018

12 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@morgo morgo deleted the morgo:analyze branch Dec 28, 2018

AndrewDi added a commit to AndrewDi/tidb that referenced this pull request Dec 28, 2018

lamxTyler added a commit to lamxTyler/tidb that referenced this pull request Jan 2, 2019

yu34po added a commit to yu34po/tidb that referenced this pull request Jan 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.