Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: fix canceling add index and add column, port from #8171 #8513

Merged
merged 6 commits into from Dec 13, 2018

Conversation

Projects
None yet
3 participants
@winkyao
Copy link
Member

winkyao commented Nov 29, 2018

What problem does this PR solve?

This PR is ported from #8171, not cherry-pick, so please review carefully.


This change is Reviewable

winkyao added some commits Nov 29, 2018

@winkyao

This comment has been minimized.

Copy link
Member Author

winkyao commented Nov 30, 2018

@crazycs520
Copy link
Contributor

crazycs520 left a comment

LGTM

@crazycs520

This comment has been minimized.

Copy link
Contributor

crazycs520 commented Dec 4, 2018

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

@winkyao

This comment has been minimized.

Copy link
Member Author

winkyao commented Dec 6, 2018

/run-sqllogic-test tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

@zimulala
Copy link
Member

zimulala left a comment

LGTM

@winkyao winkyao merged commit ffc8f6c into pingcap:release-2.0 Dec 13, 2018

11 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@winkyao winkyao deleted the winkyao:cherry-pick-2.0-cancel branch Dec 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.