Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: for UNION statements, ORDER BY cannot use column references including a table name (#8389) #8514

Merged
merged 4 commits into from Dec 13, 2018

Conversation

Projects
None yet
6 participants
@dbjoa
Copy link
Contributor

commented Nov 29, 2018

What problem does this PR solve?

Cherry-pick from #8389 to release-2.0 branch


This change is Reviewable

dbjoa added some commits Nov 29, 2018

planner: for UNION statements, ORDER BY cannot use column references …
…including a table name (#8389)

# Conflicts:
#	cmd/explaintest/r/explain_easy.result
#	plan/errors.go
#	plan/expression_rewriter.go
#	plan/logical_plan_builder.go
#	plan/physical_plan_test.go
@sre-bot

This comment has been minimized.

Copy link

commented Nov 29, 2018

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@zz-jason

This comment has been minimized.

Copy link
Member

commented Nov 29, 2018

@dbjoa CI failed.

dbjoa and others added some commits Nov 29, 2018

@ngaut

This comment has been minimized.

Copy link
Member

commented Dec 12, 2018

/run-all-tests

@ngaut

This comment has been minimized.

Copy link
Member

commented Dec 12, 2018

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

@eurekaka
Copy link
Contributor

left a comment

LGTM

@zz-jason
Copy link
Member

left a comment

LGTM

@zz-jason zz-jason merged commit 240fd12 into pingcap:release-2.0 Dec 13, 2018

12 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@zz-jason zz-jason added status/LGT2 and removed status/LGT1 labels Dec 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.