Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Txn() function signature refactor and remove ActivePendingTxn() (#8327) #8570

Merged
merged 1 commit into from Dec 5, 2018

Conversation

Projects
None yet
3 participants
@tiancaiamao
Copy link
Contributor

commented Dec 4, 2018

What problem does this PR solve?
Cherry pick from #8327

What is changed and how it works?
I thought #8327 is just a simple refactor, so I did not cherry pick that to release 2.0

But later it turns out that without the commit, release 2.0 will fail on this test #8566

@crazycs520 @winkyao


This change is Reviewable

@tiancaiamao

This comment has been minimized.

Copy link
Contributor Author

commented Dec 4, 2018

/run-all-tests tidb-test=pr/673

@winkyao
Copy link
Member

left a comment

LGTM

@zz-jason
Copy link
Member

left a comment

LGTM

@zz-jason zz-jason merged commit ed6e8ff into pingcap:release-2.0 Dec 5, 2018

11 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tidb/mybatis-test Jenkins job succeeded.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job succeeded.
Details
jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@tiancaiamao tiancaiamao deleted the tiancaiamao:cherry-2.0-fix-txn branch Dec 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.