Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: fix incorrect date arithmitical with negative interval (#8523) #8574

Merged
merged 1 commit into from Dec 5, 2018

Conversation

Projects
None yet
4 participants
@lerencao
Copy link
Contributor

lerencao commented Dec 4, 2018

What problem does this PR solve?

cherry pick #8523 to release-2.1

What is changed and how it works?

No conflict happened during cherry-picking.

Check List

Tests

  • Unit test

This change is Reviewable

@sre-bot

This comment has been minimized.

Copy link

sre-bot commented Dec 4, 2018

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@lerencao lerencao changed the title expression: fix incorrect date arithmitical with negative interval expression: fix incorrect date arithmitical with negative interval (#8523) Dec 4, 2018

@zz-jason

This comment has been minimized.

Copy link
Member

zz-jason commented Dec 4, 2018

LGTM

@eurekaka
Copy link
Contributor

eurekaka left a comment

LGTM

@eurekaka

This comment has been minimized.

Copy link
Contributor

eurekaka commented Dec 4, 2018

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

1 similar comment
@zz-jason

This comment has been minimized.

Copy link
Member

zz-jason commented Dec 4, 2018

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@zz-jason zz-jason merged commit b4b9f21 into pingcap:release-2.1 Dec 5, 2018

11 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tidb/mybatis-test Jenkins job succeeded.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job succeeded.
Details
jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.