Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: handle corrupted length in uncompress builtin function #8606

Merged
merged 2 commits into from Dec 7, 2018

Conversation

Projects
None yet
5 participants
@ziyi-yan
Copy link
Contributor

ziyi-yan commented Dec 6, 2018

What problem does this PR solve?

fixes #8578 on release-2.1

What is changed and how it works?

cherry-pick a bug fix commit(e61bad0) from this PR.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the tidb-ansible repository
  • Need to be included in the release note

This change is Reviewable

@sre-bot

This comment has been minimized.

Copy link

sre-bot commented Dec 6, 2018

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@ziyi-yan

This comment has been minimized.

Copy link
Contributor Author

ziyi-yan commented Dec 6, 2018

@zz-jason PTAL

@jackysp

This comment has been minimized.

Copy link
Member

jackysp commented Dec 7, 2018

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@jackysp
Copy link
Member

jackysp left a comment

LGTM

@zz-jason
Copy link
Member

zz-jason left a comment

LGTM

@zz-jason zz-jason merged commit 4dad722 into pingcap:release-2.1 Dec 7, 2018

11 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tidb/mybatis-test Jenkins job succeeded.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job succeeded.
Details
jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.