Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: update parser to make TiDB treat charset and collate case insensitive (#8577) #8611

Merged
merged 5 commits into from Dec 12, 2018

Conversation

Projects
None yet
6 participants
@winkyao
Copy link
Member

winkyao commented Dec 7, 2018

Cherry-pick from #8577

Merge pingcap/parser#70 first. I will update the go.mod after the parser pr is merged.


This change is Reviewable

@jackysp

This comment has been minimized.

Copy link
Member

jackysp commented Dec 7, 2018

@jackysp
Copy link
Member

jackysp left a comment

LGTM

winkyao added some commits Dec 7, 2018

@winkyao

This comment has been minimized.

Copy link
Member Author

winkyao commented Dec 8, 2018

go.mod is updated.

@winkyao

This comment has been minimized.

Copy link
Member Author

winkyao commented Dec 9, 2018

@tiancaiamao

This comment has been minimized.

Copy link
Contributor

tiancaiamao commented Dec 10, 2018

LGTM

@tiancaiamao

This comment has been minimized.

Copy link
Contributor

tiancaiamao commented Dec 10, 2018

/run-all-tests tidb-test=release-2.1

@winkyao

This comment has been minimized.

Copy link
Member Author

winkyao commented Dec 10, 2018

/run-all-tests tikv=release-2.1 tidb-test=release-2.1 pd=release-2.1

2 similar comments
@zhouqiang-cl

This comment has been minimized.

Copy link
Member

zhouqiang-cl commented Dec 11, 2018

/run-all-tests tikv=release-2.1 tidb-test=release-2.1 pd=release-2.1

@winkyao

This comment has been minimized.

Copy link
Member Author

winkyao commented Dec 11, 2018

/run-all-tests tikv=release-2.1 tidb-test=release-2.1 pd=release-2.1

@ciscoxll
Copy link
Contributor

ciscoxll left a comment

LGTM

@winkyao winkyao merged commit f3dc5ee into pingcap:release-2.1 Dec 12, 2018

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci Your tests passed on CircleCI!
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@winkyao winkyao deleted the winkyao:cherry-pick-2,1 branch Dec 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.