Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: fix abs push down sign bug (#8622) #8628

Merged
merged 5 commits into from Dec 12, 2018

Conversation

Projects
None yet
5 participants
@lysu
Copy link
Member

lysu commented Dec 10, 2018

cherry-pick #8622 to 2.1


This change is Reviewable

@lysu

This comment has been minimized.

Copy link
Member Author

lysu commented Dec 10, 2018

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@zhouqiang-cl

This comment has been minimized.

Copy link
Member

zhouqiang-cl commented Dec 10, 2018

Can we use tidb-test master? some script in tidb-test not cherry-pick to release2.1 now

@lysu

This comment has been minimized.

Copy link
Member Author

lysu commented Dec 10, 2018

@zhouqiang-cl run tidb-test@master with 2.1/2.0 branch code maybe cannot pass all testcase

@zz-jason

This comment has been minimized.

Copy link
Member

zz-jason commented Dec 10, 2018

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@zz-jason

This comment has been minimized.

Copy link
Member

zz-jason commented Dec 10, 2018

LGTM

@zz-jason

This comment has been minimized.

Copy link
Member

zz-jason commented Dec 10, 2018

@zz-jason

This comment has been minimized.

Copy link
Member

zz-jason commented Dec 10, 2018

@zhouqiang-cl Seems the CI script is not correct:


2s
+ curl --output /dev/null --silent --head --fail http://172.16.30.25/download/builds/pingcap/tidb-test/422f0e12210746b6fd4a5e48215ca096db35881a/centos7/tidb-test.tar.gz

+ curl http://172.16.30.25/download/builds/pingcap/tidb-test/422f0e12210746b6fd4a5e48215ca096db35881a/centos7/tidb-test.tar.gz

+ tar xz

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current

                                 Dload  Upload   Total   Spent    Left  Speed


  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 9829k  100 9829k    0     0  19.9M      0 --:--:-- --:--:-- --:--:-- 19.9M

+ mkdir -p /go/pkg/mod

+ mkdir -p /home/jenkins/workspace/tidb_ghpr_common_test/go/pkg

+ ln -sT /go/pkg/mod /home/jenkins/workspace/tidb_ghpr_common_test/go/pkg/mod

+ cd tidb_test

+ GOPATH=/home/jenkins/workspace/tidb_ghpr_common_test/go

+ ./build.sh

/home/jenkins/workspace/tidb_ghpr_common_test/go/src/github.com/pingcap/tidb-test@tmp/durable-0ac97380/script.sh: line 5: ./build.sh: No such file or directory

+ cd mysql_test

/home/jenkins/workspace/tidb_ghpr_common_test/go/src/github.com/pingcap/tidb-test@tmp/durable-0ac97380/script.sh: line 6: cd: mysql_test: No such file or directory

+ cd randgen-test

/home/jenkins/workspace/tidb_ghpr_common_test/go/src/github.com/pingcap/tidb-test@tmp/durable-0ac97380/script.sh: line 7: cd: randgen-test: No such file or directory

+ cd analyze_test

/home/jenkins/workspace/tidb_ghpr_common_test/go/src/github.com/pingcap/tidb-test@tmp/durable-0ac97380/script.sh: line 8: cd: analyze_test: No such file or directory

script returned exit code 1

PTAL

@zz-jason

This comment has been minimized.

Copy link
Member

zz-jason commented Dec 10, 2018

Can we use tidb-test master? some script in tidb-test not cherry-pick to release2.1 now

@zhouqiang-cl We can't. tidb 2.1 have to run the test of tidb-test 2.1

@zhouqiang-cl

This comment has been minimized.

Copy link
Member

zhouqiang-cl commented Dec 11, 2018

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@winoros
Copy link
Member

winoros left a comment

lgtm

@lysu

This comment has been minimized.

Copy link
Member Author

lysu commented Dec 11, 2018

/rebuild

1 similar comment
@zz-jason

This comment has been minimized.

Copy link
Member

zz-jason commented Dec 11, 2018

/rebuild

@zimulala zimulala added status/LGT2 and removed status/LGT1 labels Dec 11, 2018

@lysu lysu requested a review from zz-jason Dec 12, 2018

@zz-jason

This comment has been minimized.

Copy link
Member

zz-jason commented Dec 12, 2018

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

zimulala and others added some commits Dec 12, 2018

@zz-jason zz-jason merged commit 4e4b225 into pingcap:release-2.1 Dec 12, 2018

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
@zhouqiang-cl

This comment has been minimized.

Copy link
Member

zhouqiang-cl commented Dec 12, 2018

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.