Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: reset bound arguments when it is executed by execute command (#8645) #8652

Merged
merged 2 commits into from Dec 12, 2018

Conversation

Projects
None yet
4 participants
@jackysp
Copy link
Member

jackysp commented Dec 11, 2018

What problem does this PR solve?

Cherry-pick #8645 to release 2.1.

PTAL @zimulala @lysu


This change is Reviewable

@zimulala
Copy link
Member

zimulala left a comment

LGTM

@zhouqiang-cl

This comment has been minimized.

Copy link
Member

zhouqiang-cl commented Dec 11, 2018

/rebuild

@lysu

lysu approved these changes Dec 11, 2018

Copy link
Member

lysu left a comment

LGTM

@lysu lysu added status/LGT2 and removed status/LGT1 labels Dec 11, 2018

@jackysp

This comment has been minimized.

Copy link
Member Author

jackysp commented Dec 12, 2018

/run-all-tests tidb-test=pr/690 tikv=release-2.1 pd=release-2.1

@jackysp jackysp merged commit dcfff79 into pingcap:release-2.1 Dec 12, 2018

12 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@jackysp jackysp deleted the jackysp:reset_params_2.1 branch Feb 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.