Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: fix panic when add index of generated column. (#8620) #8676

Merged
merged 6 commits into from Dec 18, 2018

Conversation

Projects
None yet
4 participants
@crazycs520
Copy link
Contributor

crazycs520 commented Dec 13, 2018

What problem does this PR solve?

cherry-pick #7862 #8620.
#8620 dependent on #7862, but #7862 is not a bug fix, so I cherry-pick together.

What is changed and how it works?


This change is Reviewable

@crazycs520

This comment has been minimized.

Copy link
Contributor Author

crazycs520 commented Dec 13, 2018

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@winkyao
Copy link
Member

winkyao left a comment

LGTM

@zimulala
Copy link
Member

zimulala left a comment

LGTM

@ciscoxll
Copy link
Contributor

ciscoxll left a comment

LGTM

@ciscoxll ciscoxll added status/LGT3 and removed status/LGT2 labels Dec 17, 2018

@crazycs520

This comment has been minimized.

Copy link
Contributor Author

crazycs520 commented Dec 18, 2018

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@crazycs520

This comment has been minimized.

Copy link
Contributor Author

crazycs520 commented Dec 18, 2018

/run-circleci

@crazycs520 crazycs520 force-pushed the crazycs520:8620-2.1 branch from 0834914 to cb10fc1 Dec 18, 2018

@crazycs520

This comment has been minimized.

Copy link
Contributor Author

crazycs520 commented Dec 18, 2018

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

crazycs520 added some commits Dec 18, 2018

@crazycs520

This comment has been minimized.

Copy link
Contributor Author

crazycs520 commented Dec 18, 2018

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@crazycs520

This comment has been minimized.

Copy link
Contributor Author

crazycs520 commented Dec 18, 2018

/rebuild

@zimulala zimulala merged commit 2106f61 into pingcap:release-2.1 Dec 18, 2018

12 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.