Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plan: build separate required physical property for children #8729

Merged
merged 1 commit into from Dec 18, 2018

Conversation

Projects
None yet
3 participants
@eurekaka
Copy link
Contributor

eurekaka commented Dec 18, 2018

cherry-pick #8635


This change is Reviewable

plan: build separate required physical property for children
For logical operator which passes the required physical property
down to its children, make a copy for it instead of direct assignment
using the original pointer.

@eurekaka eurekaka force-pushed the eurekaka:release-2.1 branch from 7e9fbc3 to 7924db0 Dec 18, 2018

@eurekaka

This comment has been minimized.

Copy link
Contributor Author

eurekaka commented Dec 18, 2018

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@eurekaka

This comment has been minimized.

Copy link
Contributor Author

eurekaka commented Dec 18, 2018

@lamxTyler
Copy link
Member

lamxTyler left a comment

LGTM

@jackysp
Copy link
Member

jackysp left a comment

LGTM

@jackysp jackysp merged commit ea1c80f into pingcap:release-2.1 Dec 18, 2018

12 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@eurekaka eurekaka deleted the eurekaka:release-2.1 branch Dec 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.