Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plan: not build dual for AntiSemiJoin when condition is constant false #8730

Merged
merged 2 commits into from Dec 18, 2018

Conversation

Projects
None yet
4 participants
@eurekaka
Copy link
Contributor

eurekaka commented Dec 18, 2018

cherry-pick #8648


This change is Reviewable

@eurekaka eurekaka force-pushed the eurekaka:pick_dual branch from 55266eb to 3ebe0fd Dec 18, 2018

@eurekaka

This comment has been minimized.

Copy link
Contributor Author

eurekaka commented Dec 18, 2018

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@eurekaka

This comment has been minimized.

Copy link
Contributor Author

eurekaka commented Dec 18, 2018

@lamxTyler

This comment has been minimized.

Copy link
Member

lamxTyler commented Dec 18, 2018

Do we need to cherry pick the test?

@winoros
Copy link
Member

winoros left a comment

lgtm

@eurekaka

This comment has been minimized.

Copy link
Contributor Author

eurekaka commented Dec 18, 2018

@lamxTyler release-2.1 branch does not contain this patch: #7842, so the test result is different, hence I dropped it.

@lamxTyler
Copy link
Member

lamxTyler left a comment

LGTM

@eurekaka

This comment has been minimized.

Copy link
Contributor Author

eurekaka commented Dec 18, 2018

/rebuild

@jackysp jackysp merged commit c06df05 into pingcap:release-2.1 Dec 18, 2018

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.