Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table: check non-BMP characters and return error when the charset is utf8 and sql mode is strict mode (#8738) #8754

Merged
merged 3 commits into from Dec 19, 2018

Conversation

Projects
None yet
3 participants
@winkyao
Copy link
Member

winkyao commented Dec 19, 2018

What problem does this PR solve?

cherry-pick from #8738


This change is Reviewable

@lysu
Copy link
Member

lysu left a comment

LGTM

@zimulala
Copy link
Member

zimulala left a comment

LGTM

@zimulala

This comment has been minimized.

Copy link
Member

zimulala commented Dec 19, 2018

/run-all-tests tikv=release-2.1 pd=release-2.1 tidb-test=release-2.1

@winkyao

This comment has been minimized.

Copy link
Member Author

winkyao commented Dec 19, 2018

/run-all-tests tikv=release-2.1 pd=release-2.1 tidb-test=release-2.1

@winkyao winkyao merged commit 122d26b into pingcap:release-2.1 Dec 19, 2018

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@winkyao winkyao deleted the winkyao:release-2.1-cherry-pick branch Dec 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.