New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling insertion issue when the dropping column's flag is not null and its state is 'WriteOnly' #8791

Merged
merged 9 commits into from Jan 5, 2019

Conversation

Projects
None yet
8 participants
@zimulala
Copy link
Member

zimulala commented Dec 24, 2018

What problem does this PR solve?

Fix issue #8654

What is changed and how it works?

When the dropping column has a not-null flag and it hasn't the default value, we can backfill the column value like "add column".

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

This change is Reviewable

@zimulala

This comment has been minimized.

Copy link
Member

zimulala commented Dec 25, 2018

/run-all-tests

Show resolved Hide resolved ddl/db_change_test.go Outdated
Show resolved Hide resolved ddl/db_change_test.go Outdated
Show resolved Hide resolved ddl/db_change_test.go Outdated
@crazycs520
Copy link
Contributor

crazycs520 left a comment

Mostly LGTM.

Show resolved Hide resolved ddl/db_change_test.go
@zimulala

This comment has been minimized.

Copy link
Member

zimulala commented Dec 26, 2018

@crazycs520
Copy link
Contributor

crazycs520 left a comment

LGTM

@crazycs520

This comment has been minimized.

Copy link
Contributor

crazycs520 commented Dec 26, 2018

/run-unit-test

Show resolved Hide resolved ddl/column.go
Show resolved Hide resolved ddl/column.go Outdated
@zimulala

This comment has been minimized.

Copy link
Member

zimulala commented Jan 2, 2019

/run-all-tests

@zimulala

This comment has been minimized.

Copy link
Member

zimulala commented Jan 2, 2019

@zhouqiang-cl

This comment has been minimized.

Copy link
Member

zhouqiang-cl commented Jan 2, 2019

/run-all-tests

@winkyao
Copy link
Member

winkyao left a comment

LGTM

@winkyao
Copy link
Member

winkyao left a comment

Please check this pr to 2.1 and 2.0 branch

@winkyao winkyao added status/LGT2 and removed status/LGT1 labels Jan 2, 2019

@ciscoxll
Copy link
Member

ciscoxll left a comment

LGTM

@ciscoxll

This comment has been minimized.

Copy link
Member

ciscoxll commented Jan 2, 2019

/run-all-tests gofail=etcd-io

@ciscoxll ciscoxll added status/LGT3 and removed status/LGT2 labels Jan 2, 2019

@winkyao

This comment has been minimized.

Copy link
Member

winkyao commented Jan 2, 2019

/run-unit-test

crazycs520 and others added some commits Jan 3, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 5, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@0c75c43). Click here to learn what that means.
The diff coverage is 57.89%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #8791   +/-   ##
=========================================
  Coverage          ?   67.52%           
=========================================
  Files             ?      363           
  Lines             ?    75099           
  Branches          ?        0           
=========================================
  Hits              ?    50710           
  Misses            ?    19912           
  Partials          ?     4477
Impacted Files Coverage Δ
ddl/ddl_api.go 74.71% <33.33%> (ø)
ddl/column.go 79.39% <62.5%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c75c43...4a9e5ef. Read the comment docs.

@ngaut ngaut merged commit cfff965 into pingcap:master Jan 5, 2019

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@zimulala zimulala deleted the zimulala:drop-column branch Jan 8, 2019

zimulala added a commit to zimulala/tidb that referenced this pull request Jan 8, 2019

Handling insertion issue when the dropping column's flag is not null …
…and its state is 'WriteOnly' (pingcap#8791)

Conflicts:
	ddl/column.go
	ddl/ddl_api.go

ngaut added a commit that referenced this pull request Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment