New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: refine cancel/rollback ddl job code. #8858

Merged
merged 10 commits into from Jan 3, 2019

Conversation

Projects
None yet
4 participants
@crazycs520
Copy link
Contributor

crazycs520 commented Dec 28, 2018

What problem does this PR solve?

This PR try to keep the code style consistent with other rolling back logic.

What is changed and how it works?

Check List

Tests

Code changes

Side effects

Related changes


This change is Reviewable

@crazycs520

This comment has been minimized.

Copy link
Contributor

crazycs520 commented Dec 28, 2018

/run-all-tests

@crazycs520

This comment has been minimized.

Copy link
Contributor

crazycs520 commented Dec 28, 2018

/run-unit-test

Show resolved Hide resolved ddl/table.go Outdated
Show resolved Hide resolved ddl/column.go
@ciscoxll
Copy link
Member

ciscoxll left a comment

LGTM

reset

@crazycs520

This comment has been minimized.

Copy link
Contributor

crazycs520 commented Jan 2, 2019

/run-all-tests

@crazycs520

This comment has been minimized.

Copy link
Contributor

crazycs520 commented Jan 2, 2019

/run-all-tests

Show resolved Hide resolved ddl/column.go Outdated
@crazycs520

This comment has been minimized.

Copy link
Contributor

crazycs520 commented Jan 3, 2019

/run-all-tests

Show resolved Hide resolved ddl/column.go

@crazycs520 crazycs520 force-pushed the crazycs520:refine-cancel-drop-table branch from bc1bec1 to f75bc64 Jan 3, 2019

@crazycs520 crazycs520 force-pushed the crazycs520:refine-cancel-drop-table branch from f75bc64 to 9e0c111 Jan 3, 2019

@crazycs520

This comment has been minimized.

Copy link
Contributor

crazycs520 commented Jan 3, 2019

/run-all-tests

@zimulala
Copy link
Member

zimulala left a comment

LGTM

@zimulala zimulala added status/LGT2 and removed status/LGT1 labels Jan 3, 2019

@winkyao
Copy link
Member

winkyao left a comment

LGTM

@winkyao

winkyao approved these changes Jan 3, 2019

@crazycs520 crazycs520 merged commit 0147e0c into pingcap:master Jan 3, 2019

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@crazycs520 crazycs520 changed the title ddl: refine cancel drop table/schema code. ddl: refine cancel/rollback ddl job code. Jan 3, 2019

@crazycs520 crazycs520 deleted the crazycs520:refine-cancel-drop-table branch Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment