Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session: add a `doNotCommit` flag to transaction when `StmtCommit` fail (#8918) #8923

Merged
merged 3 commits into from Jan 3, 2019

Conversation

Projects
None yet
4 participants
@tiancaiamao
Copy link
Contributor

tiancaiamao commented Jan 3, 2019

Cherry-pick from #8918

@winkyao @lysu @crazycs520


This change is Reviewable

@tiancaiamao

This comment has been minimized.

Copy link
Contributor Author

tiancaiamao commented Jan 3, 2019

/run-all-tests tidb-test=release-2.0

@winkyao
Copy link
Member

winkyao left a comment

LGTM

@crazycs520
Copy link
Contributor

crazycs520 left a comment

LGTM

@tiancaiamao

This comment has been minimized.

Copy link
Contributor Author

tiancaiamao commented Jan 3, 2019

/run-all-tests tikv=release-2.0 tidb-test=release-2.0 pd=release-2.0 gofail=etcd-io

@lysu
Copy link
Member

lysu left a comment

LGTM

@winkyao winkyao merged commit 3ce42ff into pingcap:release-2.0 Jan 3, 2019

12 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@tiancaiamao tiancaiamao deleted the tiancaiamao:not-commit-2.0 branch Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.