Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
ddl: support altering the other charset to utf8 or utf8mb4 (#8037) #8951
What problem does this PR solve?
CREATE TABLE tt ( a varchar(64) CHARACTER SET utf8 COLLATE utf8_bin NOT NULL DEFAULT '' ) CHARACTER SET = utf8 COLLATE = utf8_general_ci; INSERT INTO tt VALUES ('🕶小楠～'); // return error. // before this PR, release 2.1 can not support change column charset. alter table tt modify column a varchar(64) CHARACTER SET utf8mb4;
What is changed and how it works?
referenced this pull request
Jan 5, 2019
Jan 7, 2019
12 checks passed
ci/circleci Your tests passed on CircleCI!Details
continuous-integration/travis-ci/pr The Travis CI build passedDetails
idc-jenkins-ci-tidb/build Jenkins job succeeded.Details
idc-jenkins-ci-tidb/common-test job succeededDetails
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.Details
idc-jenkins-ci-tidb/mybatis-test job succeededDetails
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.Details
license/cla Contributor License Agreement is signed.Details
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews.