Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: support altering the other charset to utf8 or utf8mb4 (#8037) #8951

Merged
merged 3 commits into from Jan 7, 2019

Conversation

Projects
None yet
4 participants
@crazycs520
Copy link
Contributor

crazycs520 commented Jan 5, 2019

What problem does this PR solve?

cherry-pick #8037 ,
Please merge pingcap/parser#152 first.

CREATE TABLE tt (
a varchar(64) CHARACTER SET utf8 COLLATE utf8_bin NOT NULL DEFAULT ''
) CHARACTER SET = utf8 COLLATE = utf8_general_ci;

INSERT INTO tt VALUES ('🕶小楠~');  // return error.

// before this PR, release 2.1 can not support change column charset.
alter table tt modify column a varchar(64) CHARACTER SET utf8mb4;

What is changed and how it works?

Check List

Tests


This change is Reviewable

winkyao and others added some commits Dec 10, 2018

@jackysp
Copy link
Member

jackysp left a comment

LGTM

@zz-jason

This comment has been minimized.

Copy link
Member

zz-jason commented Jan 5, 2019

@crazycs520 Please add some proper labels. For example, component, type.

@zz-jason
Copy link
Member

zz-jason left a comment

LGTM

@zz-jason

This comment has been minimized.

Copy link
Member

zz-jason commented Jan 5, 2019

/run-all-tests tidb-test=release-2.1 pd=release-2.1 tikv=release-2.1

@winkyao
Copy link
Member

winkyao left a comment

lgtm

@crazycs520 crazycs520 dismissed stale reviews from winkyao and zz-jason via 082007d Jan 7, 2019

@crazycs520

This comment has been minimized.

Copy link
Contributor Author

crazycs520 commented Jan 7, 2019

/run-all-tests tidb-test=release-2.1 pd=release-2.1 tikv=release-2.1

@crazycs520

This comment has been minimized.

Copy link
Contributor Author

crazycs520 commented Jan 7, 2019

/run-all-tests tidb-test=pr/713 pd=release-2.1 tikv=release-2.1

@crazycs520

This comment has been minimized.

Copy link
Contributor Author

crazycs520 commented Jan 7, 2019

/run-all-tests tidb-test=release-2.1 pd=release-2.1 tikv=release-2.1

@crazycs520

This comment has been minimized.

Copy link
Contributor Author

crazycs520 commented Jan 7, 2019

/run-all-tests tidb-test=pr/713 pd=release-2.1 tikv=release-2.1

@jackysp

jackysp approved these changes Jan 7, 2019

@jackysp jackysp merged commit 665db64 into pingcap:release-2.1 Jan 7, 2019

12 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.