Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plan/executor: handle optimizer hint properly for cartesian join #9037

Merged
merged 5 commits into from Jan 14, 2019

Conversation

@eurekaka
Copy link
Contributor

commented Jan 14, 2019

What problem does this PR solve?

Fix #9032

What is changed and how it works?

  • allow merge join executor to handle cartesian product;
  • raise warning and choose other join implementations if TIDB_INLJ is specified;

Check List

Tests

  • Unit test

Code changes

N/A

Side effects

N/A

Related changes

  • Need to cherry-pick to the release branch
@eurekaka

This comment has been minimized.

Copy link
Contributor Author

commented Jan 14, 2019

/run-all-tests

@zz-jason
Copy link
Member

left a comment

LGTM

Show resolved Hide resolved planner/core/exhaust_physical_plans.go Outdated
Show resolved Hide resolved executor/merge_join_test.go
@eurekaka

This comment has been minimized.

Copy link
Contributor Author

commented Jan 14, 2019

/run-unit-test

@eurekaka

This comment has been minimized.

Copy link
Contributor Author

commented Jan 14, 2019

Comments addressed, @XuHuaiyu PTAL

@eurekaka eurekaka added the status/DNM label Jan 14, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jan 14, 2019

Codecov Report

Merging #9037 into master will decrease coverage by 0.02%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9037      +/-   ##
==========================================
- Coverage   67.28%   67.26%   -0.03%     
==========================================
  Files         371      371              
  Lines       75930    75920      -10     
==========================================
- Hits        51092    51070      -22     
- Misses      20332    20346      +14     
+ Partials     4506     4504       -2
Impacted Files Coverage Δ
executor/merge_join.go 81.5% <0%> (ø) ⬆️
planner/core/exhaust_physical_plans.go 92.1% <100%> (+0.03%) ⬆️
ddl/delete_range.go 74.28% <0%> (-4.58%) ⬇️
planner/core/planbuilder.go 49.07% <0%> (-1.05%) ⬇️
executor/index_lookup_join.go 77.28% <0%> (-0.64%) ⬇️
executor/executor.go 66.66% <0%> (-0.15%) ⬇️
planner/core/logical_plan_builder.go 74.98% <0%> (+0.25%) ⬆️
executor/join.go 78.44% <0%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f346a3...836e32f. Read the comment docs.

@eurekaka eurekaka removed the status/DNM label Jan 14, 2019

@eurekaka eurekaka requested a review from XuHuaiyu Jan 14, 2019

@XuHuaiyu
Copy link
Contributor

left a comment

LGTM

@XuHuaiyu XuHuaiyu added status/LGT2 and removed status/LGT1 labels Jan 14, 2019

@eurekaka eurekaka merged commit 4a901db into pingcap:master Jan 14, 2019

4 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci Your tests passed on CircleCI!
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@eurekaka eurekaka deleted the eurekaka:merge_join_cartesian branch Jan 14, 2019

zz-jason added a commit that referenced this pull request Jan 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.