New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: handle Float32 for builtin function Values() #9215

Merged
merged 2 commits into from Jan 30, 2019

Conversation

Projects
None yet
4 participants
@zz-jason
Copy link
Member

zz-jason commented Jan 29, 2019

Signed-off-by: Jian Zhang zjsariel@gmail.com

What problem does this PR solve?

fix #8934

What is changed and how it works?

The builtin function Values() should get a floag32 value from the input Chunk when it's output type is mysql.TypeFloat.

Only Column and builtinValuesRealSig call Chunk.GetFloat64(). Column has handled the float32 input value correctly.

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch
expression: handle Float32 for builtin function Values()
Signed-off-by: Jian Zhang <zjsariel@gmail.com>
@zz-jason

This comment has been minimized.

Copy link
Member Author

zz-jason commented Jan 29, 2019

/run-all-tests

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 29, 2019

Codecov Report

Merging #9215 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9215      +/-   ##
==========================================
- Coverage   67.22%   67.21%   -0.01%     
==========================================
  Files         371      371              
  Lines       77050    77052       +2     
==========================================
- Hits        51800    51794       -6     
- Misses      20625    20631       +6     
- Partials     4625     4627       +2
Impacted Files Coverage Δ
expression/builtin_other.go 65.36% <100%> (+0.16%) ⬆️
ddl/delete_range.go 75.13% <0%> (-4.24%) ⬇️
store/tikv/scan.go 73.94% <0%> (-3.37%) ⬇️
executor/join.go 78.9% <0%> (+1.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09a5c80...89b0235. Read the comment docs.

@XuHuaiyu
Copy link
Contributor

XuHuaiyu left a comment

LGTM

@eurekaka
Copy link
Contributor

eurekaka left a comment

LGTM

@zz-jason zz-jason merged commit b3bdc5d into pingcap:master Jan 30, 2019

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@zz-jason zz-jason deleted the zz-jason:bugfix/values-float32 branch Jan 30, 2019

zz-jason added a commit to zz-jason/tidb that referenced this pull request Jan 30, 2019

zz-jason added a commit to zz-jason/tidb that referenced this pull request Jan 30, 2019

zz-jason added a commit that referenced this pull request Jan 30, 2019

zz-jason added a commit that referenced this pull request Jan 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment