New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: fix a bug in baseFuncDesc.clone() #9254

Merged
merged 2 commits into from Feb 10, 2019

Conversation

Projects
None yet
4 participants
@bb7133
Copy link
Contributor

bb7133 commented Feb 5, 2019

What problem does this PR solve?

Trivially fix a slice copy bug in aggreation.baseFuncDesc.clone()

What is changed and how it works?

It creates a new slice when cloning the struct

Tests

  • Unit test

Code changes

  • No

Side effects

  • No

Related changes

  • No

@bb7133 bb7133 force-pushed the bb7133:bb7133/fix_agg_desc_clone branch from c9f31ad to 7826309 Feb 7, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 7, 2019

Codecov Report

Merging #9254 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9254      +/-   ##
==========================================
+ Coverage   67.22%   67.25%   +0.02%     
==========================================
  Files         371      371              
  Lines       77149    77150       +1     
==========================================
+ Hits        51866    51886      +20     
+ Misses      20649    20632      -17     
+ Partials     4634     4632       -2
Impacted Files Coverage Δ
expression/aggregation/base_func.go 50.37% <100%> (+9.46%) ⬆️
executor/executor.go 67.31% <0%> (+0.27%) ⬆️
store/tikv/lock_resolver.go 42.65% <0%> (+0.94%) ⬆️
util/systimemon/systime_mon.go 100% <0%> (+20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d614e0...8f6f719. Read the comment docs.

@zz-jason
Copy link
Member

zz-jason left a comment

LGTM

@zz-jason

This comment has been minimized.

Copy link
Member

zz-jason commented Feb 7, 2019

/run-all-tests

@ngaut

This comment has been minimized.

Copy link
Member

ngaut commented Feb 10, 2019

/run-all-tests

@ngaut

ngaut approved these changes Feb 10, 2019

Copy link
Member

ngaut left a comment

LGTM

@ngaut ngaut merged commit ee1f79e into pingcap:master Feb 10, 2019

13 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
@bb7133

This comment has been minimized.

Copy link
Contributor Author

bb7133 commented Feb 12, 2019

Thanks for the review @zz-jason @ngaut

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment