New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: enable function `any_value` in aggregation if `ONLY_FULL_GROUP_BY` is set #9255

Merged
merged 3 commits into from Feb 10, 2019

Conversation

Projects
None yet
4 participants
@spongedu
Copy link
Contributor

spongedu commented Feb 6, 2019

What problem does this PR solve?

Fix issue #8161
any_value can be used in aggregation even if ONLY_FULL_GROUP_BY is set. see MySQL Referernce.

What is changed and how it works?

Take special care of any_value when validate aggregations in logical_plan_builder.go.

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

@spongedu

This comment has been minimized.

Copy link
Contributor Author

spongedu commented Feb 6, 2019

@morgo @zz-jason PTAL

@zz-jason
Copy link
Member

zz-jason left a comment

LGTM

@zz-jason

This comment has been minimized.

Copy link
Member

zz-jason commented Feb 7, 2019

/run-all-tests

@spongedu spongedu referenced this pull request Feb 8, 2019

Closed

Add remaining miscellaneous functions #8439

16 of 17 tasks complete
@ngaut

ngaut approved these changes Feb 10, 2019

Copy link
Member

ngaut left a comment

LGTM

@ngaut ngaut merged commit 3d614e0 into pingcap:master Feb 10, 2019

4 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci Your tests passed on CircleCI!
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 10, 2019

Codecov Report

Merging #9255 into master will decrease coverage by <.01%.
The diff coverage is 22.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9255      +/-   ##
==========================================
- Coverage   67.23%   67.23%   -0.01%     
==========================================
  Files         371      371              
  Lines       77142    77149       +7     
==========================================
+ Hits        51869    51872       +3     
- Misses      20642    20647       +5     
+ Partials     4631     4630       -1
Impacted Files Coverage Δ
planner/core/logical_plan_builder.go 74.64% <22.22%> (-0.23%) ⬇️
ddl/session_pool.go 82.75% <0%> (-10.35%) ⬇️
expression/schema.go 94.11% <0%> (-0.85%) ⬇️
executor/index_lookup_join.go 77.28% <0%> (-0.64%) ⬇️
executor/join.go 77.86% <0%> (-0.53%) ⬇️
util/filesort/filesort.go 76.17% <0%> (-0.32%) ⬇️
executor/executor.go 67.31% <0%> (+0.27%) ⬆️
executor/distsql.go 73% <0%> (+0.46%) ⬆️
infoschema/infoschema.go 77.63% <0%> (+1.31%) ⬆️
ddl/delete_range.go 77.77% <0%> (+2.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a90503...c85133b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment