Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: adjust message about Charset&&Collation in 'show create table` for compatibility #9306

Merged
merged 5 commits into from Feb 15, 2019

Conversation

Projects
None yet
4 participants
@xiekeyi98
Copy link
Contributor

xiekeyi98 commented Feb 14, 2019

What problem does this PR solve?

Cherry-pick from #9113

@xiekeyi98

This comment has been minimized.

Copy link
Contributor Author

xiekeyi98 commented Feb 14, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

1 similar comment
@xiekeyi98

This comment has been minimized.

Copy link
Contributor Author

xiekeyi98 commented Feb 14, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@zimulala

This comment has been minimized.

Copy link
Member

zimulala commented Feb 15, 2019

Please fix the CI.

@jackysp jackysp added the status/DNM label Feb 15, 2019

xiekeyi98 added some commits Feb 14, 2019

@xiekeyi98 xiekeyi98 force-pushed the xiekeyi98:cherrypick#9113 branch from aa6de0b to 35513a9 Feb 15, 2019

@xiekeyi98

This comment has been minimized.

Copy link
Contributor Author

xiekeyi98 commented Feb 15, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@xiekeyi98

This comment has been minimized.

Copy link
Contributor Author

xiekeyi98 commented Feb 15, 2019

/run-all-tests tidb-test=pr/736 tikv=release-2.1 pd=release-2.1

@xiekeyi98

This comment has been minimized.

Copy link
Contributor Author

xiekeyi98 commented Feb 15, 2019

/run-common-tests tidb-test=pr/736 tikv=release-2.1 pd=release-2.1

1 similar comment
@xiekeyi98

This comment has been minimized.

Copy link
Contributor Author

xiekeyi98 commented Feb 15, 2019

/run-common-tests tidb-test=pr/736 tikv=release-2.1 pd=release-2.1

@xiekeyi98

This comment has been minimized.

Copy link
Contributor Author

xiekeyi98 commented Feb 15, 2019

/run-all-tests tidb-test=pr/736 tikv=release-2.1 pd=release-2.1

@zimulala
Copy link
Member

zimulala left a comment

LGTM

@zz-jason
Copy link
Member

zz-jason left a comment

LGTM

@zz-jason zz-jason added status/LGT2 and removed status/LGT1 labels Feb 15, 2019

@zz-jason zz-jason merged commit 1aa05f8 into pingcap:release-2.1 Feb 15, 2019

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@xiekeyi98 xiekeyi98 deleted the xiekeyi98:cherrypick#9113 branch Feb 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.