Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor,planner: support show create view #9309

Merged
merged 6 commits into from Feb 19, 2019

Conversation

@AndrewDi
Copy link
Contributor

commented Feb 14, 2019

What problem does this PR solve?

As part of view feature, add SHOW CREATE VIEW grammar support.

What is changed and how it works?

ref proposal Proposal: Implement View

Check List

Tests

  • Unit test

@AndrewDi AndrewDi changed the title View/show create view executor,planner: support show create view Feb 14, 2019

@AndrewDi

This comment has been minimized.

Copy link
Contributor Author

commented Feb 14, 2019

/run-all-tests

@AndrewDi

This comment has been minimized.

Copy link
Contributor Author

commented Feb 14, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Feb 14, 2019

Codecov Report

Merging #9309 into master will increase coverage by <.01%.
The diff coverage is 41.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9309      +/-   ##
==========================================
+ Coverage   67.13%   67.13%   +<.01%     
==========================================
  Files         372      372              
  Lines       77747    77768      +21     
==========================================
+ Hits        52192    52208      +16     
- Misses      20887    20890       +3     
- Partials     4668     4670       +2
Impacted Files Coverage Δ
ddl/ddl.go 89.53% <ø> (ø) ⬆️
planner/core/planbuilder.go 49.39% <0%> (-0.21%) ⬇️
ddl/ddl_api.go 74.76% <0%> (ø) ⬆️
executor/errors.go 100% <100%> (ø) ⬆️
executor/show.go 43.87% <60%> (+0.36%) ⬆️
executor/join.go 78.38% <0%> (+0.52%) ⬆️
store/tikv/lock_resolver.go 42.65% <0%> (+0.94%) ⬆️
infoschema/infoschema.go 77.63% <0%> (+1.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed7bb00...13d1272. Read the comment docs.

@zz-jason zz-jason added this to In progress in Support View via automation Feb 15, 2019

@zz-jason zz-jason moved this from In progress to Needs review in Support View Feb 15, 2019

Show resolved Hide resolved executor/errors.go Outdated
@winkyao
Copy link
Member

left a comment

LGTM

@zz-jason
Copy link
Member

left a comment

LGTM

Support View automation moved this from Needs review to Reviewer approved Feb 16, 2019

@zz-jason

This comment has been minimized.

Copy link
Member

commented Feb 16, 2019

/run-all-tests

@AndrewDi

This comment has been minimized.

Copy link
Contributor Author

commented Feb 16, 2019

@zz-jason Does common-test has broken?

@zz-jason

This comment has been minimized.

Copy link
Member

commented Feb 16, 2019

@zz-jason Does common-test has broken?

oops, let me take a look

@zz-jason

This comment has been minimized.

Copy link
Member

commented Feb 17, 2019

/run-common-test

@zz-jason

This comment has been minimized.

Copy link
Member

commented Feb 17, 2019

@AndrewDi The CI is broken by #9331. We'll try to fix it as soon as possible.

@zz-jason

This comment has been minimized.

Copy link
Member

commented Feb 19, 2019

/run-common-test
/run-integration-common-test
/run-unit-test

@zz-jason zz-jason removed the request for review from XuHuaiyu Feb 19, 2019

@zz-jason zz-jason merged commit b845f2a into pingcap:master Feb 19, 2019

8 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

Support View automation moved this from Reviewer approved to Done Feb 19, 2019

yu34po added a commit to yu34po/tidb that referenced this pull request Feb 27, 2019

@AndrewDi AndrewDi deleted the AndrewDi:view/show_create_view branch Mar 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.