Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control the number of rows in chunks returned by LimitExec #9354

Merged
merged 5 commits into from Feb 19, 2019

Conversation

Projects
None yet
4 participants
@qw4990
Copy link
Contributor

commented Feb 19, 2019

What problem does this PR solve?

Control the number of rows in chunks returned by LimitExec.
Following up #9293, this PR is a subtask of #9166.

What is changed and how it works?

  • Introduce adjustRequiredRows into LimitExec to adjust the required rows before each call of
    child's Next.
  • Introduce requiredRowsDataSource as mock DataSource when test.
  • Add some unit tests for LimitExec.

Check List

Tests

  • Unit test

@qw4990 qw4990 requested review from lysu, zz-jason and XuHuaiyu Feb 19, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Feb 19, 2019

Codecov Report

Merging #9354 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9354      +/-   ##
==========================================
+ Coverage   67.05%   67.07%   +0.02%     
==========================================
  Files         372      372              
  Lines       78043    78053      +10     
==========================================
+ Hits        52332    52357      +25     
+ Misses      21033    21023      -10     
+ Partials     4678     4673       -5
Impacted Files Coverage Δ
executor/executor.go 67.89% <100%> (+0.86%) ⬆️
store/tikv/lock_resolver.go 41.7% <0%> (-0.95%) ⬇️
ddl/delete_range.go 79.36% <0%> (+5.82%) ⬆️
ddl/session_pool.go 93.1% <0%> (+10.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45ee205...286f7cd. Read the comment docs.

@zz-jason
Copy link
Member

left a comment

LGTM

@qw4990

This comment has been minimized.

Copy link
Contributor Author

commented Feb 19, 2019

PTAL~ @lysu

@qw4990

This comment has been minimized.

Copy link
Contributor Author

commented Feb 19, 2019

/run-all-tests

@qw4990 qw4990 force-pushed the qw4990:chunkSizeControl_Limit branch from f67e3e5 to 3cc5837 Feb 19, 2019

@qw4990

This comment has been minimized.

Copy link
Contributor Author

commented Feb 19, 2019

/run-all-tests

@lysu

lysu approved these changes Feb 19, 2019

Copy link
Member

left a comment

LGTM

@lysu lysu added the status/LGT2 label Feb 19, 2019

@qw4990 qw4990 merged commit 789f700 into pingcap:master Feb 19, 2019

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

qw4990 added a commit to qw4990/tidb that referenced this pull request Feb 19, 2019

ngaut added a commit that referenced this pull request Feb 20, 2019

yu34po added a commit to yu34po/tidb that referenced this pull request Feb 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.