Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: support row framed window functions #9358

Merged
merged 3 commits into from Feb 21, 2019

Conversation

@lamxTyler
Copy link
Member

commented Feb 19, 2019

What problem does this PR solve?

Support row framed window functions.
Refer https://dev.mysql.com/doc/refman/8.0/en/window-functions-frames.html

What is changed and how it works?

  • Extract an interface to processing different kinds of windows.
  • Adapt the window executor to also support row framed windows.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

  • None

Related changes

  • None

@lamxTyler lamxTyler added this to In progress in window function via automation Feb 19, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Feb 19, 2019

Codecov Report

Merging #9358 into master will increase coverage by <.01%.
The diff coverage is 76.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9358      +/-   ##
==========================================
+ Coverage   67.16%   67.17%   +<.01%     
==========================================
  Files         373      373              
  Lines       78193    78269      +76     
==========================================
+ Hits        52521    52574      +53     
- Misses      20972    20991      +19     
- Partials     4700     4704       +4
Impacted Files Coverage Δ
executor/builder.go 83.6% <100%> (+0.3%) ⬆️
executor/window.go 68.35% <71.95%> (+1.3%) ⬆️
util/systimemon/systime_mon.go 80% <0%> (-20%) ⬇️
infoschema/infoschema.go 76.31% <0%> (-1.32%) ⬇️
expression/schema.go 93.75% <0%> (-0.79%) ⬇️
executor/distsql.go 71.78% <0%> (-0.46%) ⬇️
ddl/delete_range.go 79.36% <0%> (+1.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5188a8...902f962. Read the comment docs.

Show resolved Hide resolved executor/window.go
Show resolved Hide resolved executor/window.go
Show resolved Hide resolved executor/window.go
@zz-jason
Copy link
Member

left a comment

LGTM

@lamxTyler lamxTyler requested review from qw4990 and winoros Feb 21, 2019

window function automation moved this from In progress to Reviewer approved Feb 21, 2019

@winoros
Copy link
Member

left a comment

lgtm

@lamxTyler lamxTyler added status/LGT2 and removed status/LGT1 labels Feb 21, 2019

@lamxTyler

This comment has been minimized.

Copy link
Member Author

commented Feb 21, 2019

/run-all-tests

@lamxTyler lamxTyler merged commit 042e410 into pingcap:master Feb 21, 2019

13 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

window function automation moved this from Reviewer approved to Done Feb 21, 2019

@lamxTyler lamxTyler deleted the lamxTyler:row-framed branch Feb 21, 2019

yu34po added a commit to yu34po/tidb that referenced this pull request Feb 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.