Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sessionctx: show correct TiDB port instead of 3306 #9365

Merged
merged 3 commits into from Feb 20, 2019

Conversation

Projects
None yet
5 participants
@morgo
Copy link
Member

commented Feb 20, 2019

What problem does this PR solve?

Fixes #9362

What is changed and how it works?

Previously TiDB lied about the port configured (showing MySQL's default of 3306).

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Code changes

  • Has exported variable/fields change

Side effects

  • Increased code complexity
  • Breaking backward compatibility (for broken apps)

Related changes

  • Need to be included in the release note

morgo added some commits Feb 20, 2019

@morgo

This comment has been minimized.

Copy link
Member Author

commented Feb 20, 2019

@jackysp PTAL

@codecov-io

This comment has been minimized.

Copy link

commented Feb 20, 2019

Codecov Report

Merging #9365 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9365      +/-   ##
==========================================
+ Coverage   67.13%   67.14%   +<.01%     
==========================================
  Files         373      373              
  Lines       78136    78136              
==========================================
+ Hits        52455    52462       +7     
+ Misses      20982    20978       -4     
+ Partials     4699     4696       -3
Impacted Files Coverage Δ
sessionctx/variable/sysvar.go 100% <ø> (ø) ⬆️
expression/schema.go 93.75% <0%> (-0.79%) ⬇️
ddl/delete_range.go 76.19% <0%> (+2.64%) ⬆️
util/systimemon/systime_mon.go 100% <0%> (+20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77fb909...96c1bb9. Read the comment docs.

@morgo morgo requested a review from jackysp Feb 20, 2019

@winoros
Copy link
Member

left a comment

lgtm

@winoros winoros added the status/LGT1 label Feb 20, 2019

@morgo

This comment has been minimized.

Copy link
Member Author

commented Feb 20, 2019

/run-all-tests

Show resolved Hide resolved sessionctx/variable/sysvar.go Outdated
Update sessionctx/variable/sysvar.go
Co-Authored-By: morgo <tocker@gmail.com>
@zz-jason
Copy link
Member

left a comment

LGTM

@zz-jason

This comment has been minimized.

Copy link
Member

commented Feb 20, 2019

/run-all-tests

@zz-jason zz-jason added status/LGT2 and removed status/LGT1 labels Feb 20, 2019

@ngaut ngaut merged commit e499da9 into pingcap:master Feb 20, 2019

13 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@morgo morgo deleted the morgo:accurate-port branch Feb 20, 2019

yu34po added a commit to yu34po/tidb that referenced this pull request Feb 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.