Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* fix timestamp default value bug in multiple time zones. (#9115) (#9108) #9399

Merged
merged 3 commits into from Feb 21, 2019

Conversation

Projects
None yet
3 participants
@crazycs520
Copy link
Contributor

crazycs520 commented Feb 21, 2019

What problem does this PR solve?

cherry-pick #9108 #9115
Related parser PR: pingcap/parser#218 please merge this first, then i will update the go.mod in tidb.

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

Related changes

  • Need to cherry-pick to the release branch
@crazycs520

This comment has been minimized.

Copy link
Contributor Author

crazycs520 commented Feb 21, 2019

/run-all-tests tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1

@zimulala
Copy link
Member

zimulala left a comment

LGTM

@winkyao
Copy link
Member

winkyao left a comment

LGTM

@winkyao
Copy link
Member

winkyao left a comment

LGTM

@winkyao winkyao merged commit 0964ad4 into pingcap:release-2.1 Feb 21, 2019

13 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@crazycs520 crazycs520 referenced this pull request Feb 21, 2019

Merged

go.mod: update parser #9402

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.