Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner/core: code refactor around join reorder #9439

Merged
merged 7 commits into from Mar 4, 2019

Conversation

Projects
None yet
5 participants
@winoros
Copy link
Member

winoros commented Feb 25, 2019

What problem does this PR solve?

some code refactor.

What is changed and how it works?

Extract common code that dp/greedy will use.

Check List

Tests

  • Unit test(existing ones can cover it).

@winoros winoros marked this pull request as ready for review Feb 25, 2019

@winoros winoros requested review from eurekaka , lamxTyler and zz-jason Feb 25, 2019

@winoros winoros force-pushed the winoros:join-order-code-refactor branch from bb038dc to fccbac0 Feb 25, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 25, 2019

Codecov Report

Merging #9439 into master will increase coverage by 0.01%.
The diff coverage is 82.02%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9439      +/-   ##
==========================================
+ Coverage   67.37%   67.39%   +0.01%     
==========================================
  Files         374      375       +1     
  Lines       78740    78746       +6     
==========================================
+ Hits        53053    53070      +17     
+ Misses      20911    20903       -8     
+ Partials     4776     4773       -3
Impacted Files Coverage Δ
planner/core/optimizer.go 61.53% <ø> (ø) ⬆️
planner/core/rule_join_reorder_greedy.go 90.47% <100%> (+5.75%) ⬆️
planner/core/rule_join_reorder.go 81.6% <81.6%> (ø)
store/tikv/2pc.go 78.61% <0%> (-1.79%) ⬇️
executor/join.go 79.58% <0%> (+0.51%) ⬆️
ddl/delete_range.go 79.36% <0%> (+5.82%) ⬆️
ddl/session_pool.go 93.1% <0%> (+10.34%) ⬆️
util/systimemon/systime_mon.go 100% <0%> (+20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e767c5b...6b6f571. Read the comment docs.

Show resolved Hide resolved planner/core/rule_join_reorder.go Outdated
Show resolved Hide resolved planner/core/rule_join_reorder.go

@winoros winoros requested review from zz-jason and lamxTyler and removed request for zz-jason Mar 4, 2019

@zz-jason
Copy link
Member

zz-jason left a comment

LGTM

@zz-jason zz-jason added the status/LGT1 label Mar 4, 2019

@zz-jason

This comment has been minimized.

Copy link
Member

zz-jason commented Mar 4, 2019

/run-all-tests

@lamxTyler
Copy link
Member

lamxTyler left a comment

LGTM

@zz-jason zz-jason merged commit f16081b into pingcap:master Mar 4, 2019

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@winoros winoros deleted the winoros:join-order-code-refactor branch Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.