Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add rollback for load data statement #9444

Merged
merged 6 commits into from Feb 28, 2019

Conversation

@crazycs520
Copy link
Contributor

commented Feb 25, 2019

What problem does this PR solve?

Add transaction rollback for load data.

What is changed and how it works?

Check List

Tests

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch
@codecov-io

This comment has been minimized.

Copy link

commented Feb 25, 2019

Codecov Report

Merging #9444 into master will increase coverage by <.01%.
The diff coverage is 46.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9444      +/-   ##
==========================================
+ Coverage   67.38%   67.39%   +<.01%     
==========================================
  Files         374      374              
  Lines       78653    78659       +6     
==========================================
+ Hits        53000    53009       +9     
+ Misses      20894    20891       -3     
  Partials     4759     4759
Impacted Files Coverage Δ
server/conn.go 59.09% <46.15%> (+0.19%) ⬆️
ddl/session_pool.go 82.75% <0%> (-10.35%) ⬇️
executor/distsql.go 71.78% <0%> (-0.46%) ⬇️
executor/executor.go 68.44% <0%> (+0.27%) ⬆️
expression/schema.go 94.53% <0%> (+0.78%) ⬆️
ddl/delete_range.go 76.19% <0%> (+1.05%) ⬆️
store/tikv/scan.go 77.31% <0%> (+3.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c97db8...beacc55. Read the comment docs.

@crazycs520

This comment has been minimized.

Copy link
Contributor Author

commented Feb 25, 2019

@crazycs520

This comment has been minimized.

Copy link
Contributor Author

commented Feb 25, 2019

/run-all-tests

@crazycs520

This comment has been minimized.

Copy link
Contributor Author

commented Feb 25, 2019

/run-all-tests

@zz-jason zz-jason requested a review from tiancaiamao Feb 25, 2019

@zz-jason
Copy link
Member

left a comment

LGTM

@crazycs520

This comment has been minimized.

Copy link
Contributor Author

commented Feb 26, 2019

Show resolved Hide resolved server/conn.go Outdated
@tiancaiamao

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2019

Please address comment, rest looks good to me

crazycs520 added some commits Feb 27, 2019

@crazycs520

This comment has been minimized.

Copy link
Contributor Author

commented Feb 27, 2019

/run-all-tests

@crazycs520

This comment has been minimized.

Copy link
Contributor Author

commented Feb 27, 2019

/run-unit-test

@jackysp
Copy link
Member

left a comment

LGTM

@jackysp jackysp requested a review from zimulala Feb 28, 2019

@crazycs520

This comment has been minimized.

Copy link
Contributor Author

commented Feb 28, 2019

@crazycs520

This comment has been minimized.

Copy link
Contributor Author

commented Feb 28, 2019

/run-all-tests

@crazycs520 crazycs520 merged commit 2c90855 into pingcap:master Feb 28, 2019

13 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@crazycs520 crazycs520 deleted the crazycs520:load-data-rollback branch Feb 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.