Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: support window function rank and dense_rank #9500

Merged
merged 2 commits into from Feb 28, 2019

Conversation

@lamxTyler
Copy link
Member

commented Feb 28, 2019

What problem does this PR solve?

Support window function rank and dense_rank.
See https://dev.mysql.com/doc/refman/8.0/en/window-function-descriptions.html#function_rank and https://dev.mysql.com/doc/refman/8.0/en/window-function-descriptions.html#function_dense-rank

For #9499

What is changed and how it works?

Implement the function using the agg function interface.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

  • None

Related changes

  • None

@lamxTyler lamxTyler added this to In progress in window function via automation Feb 28, 2019

@lamxTyler lamxTyler requested review from zz-jason, qw4990 and winoros Feb 28, 2019

@lamxTyler lamxTyler referenced this pull request Feb 28, 2019

Closed

support all window functions #9499

11 of 11 tasks complete
@codecov-io

This comment has been minimized.

Copy link

commented Feb 28, 2019

Codecov Report

Merging #9500 into master will decrease coverage by 0.05%.
The diff coverage is 6.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9500      +/-   ##
==========================================
- Coverage   67.42%   67.37%   -0.06%     
==========================================
  Files         373      374       +1     
  Lines       78568    78620      +52     
==========================================
- Hits        52976    52969       -7     
- Misses      20837    20892      +55     
- Partials     4755     4759       +4
Impacted Files Coverage Δ
executor/aggfuncs/builder.go 32.12% <0%> (-2.51%) ⬇️
executor/aggfuncs/func_rank.go 0% <0%> (ø)
expression/aggregation/base_func.go 48.2% <0%> (ø) ⬆️
executor/builder.go 83.82% <100%> (+0.03%) ⬆️
ddl/delete_range.go 75.13% <0%> (-5.3%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddbf60f...85b9297. Read the comment docs.

@winoros
Copy link
Member

left a comment

lgtm

window function automation moved this from In progress to Reviewer approved Feb 28, 2019

@zz-jason
Copy link
Member

left a comment

LGTM

@zz-jason

This comment has been minimized.

Copy link
Member

commented Feb 28, 2019

/run-all-tests

@zz-jason

This comment has been minimized.

Copy link
Member

commented Feb 28, 2019

/run-integration-compatibility-test

@zz-jason zz-jason merged commit 9259785 into pingcap:master Feb 28, 2019

13 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

window function automation moved this from Reviewer approved to Done Feb 28, 2019

@lamxTyler lamxTyler deleted the lamxTyler:rank branch Feb 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.