Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sessionctx/variable: fix panic when set variable='' (#9533) #9539

Merged
merged 2 commits into from Mar 4, 2019

Conversation

Projects
None yet
3 participants
@crazycs520
Copy link
Contributor

commented Mar 4, 2019

What problem does this PR solve?

cherry-pick #9533

What is changed and how it works?

Check List

@crazycs520

This comment has been minimized.

Copy link
Contributor Author

commented Mar 4, 2019

/run-all-tests tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1

@crazycs520

This comment has been minimized.

Copy link
Contributor Author

commented Mar 4, 2019

/run-all-tests tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1

@zz-jason
Copy link
Member

left a comment

LGTM

@zz-jason zz-jason requested a review from eurekaka Mar 4, 2019

@zz-jason zz-jason added the status/LGT1 label Mar 4, 2019

@shenli

shenli approved these changes Mar 4, 2019

Copy link
Member

left a comment

LGTM

@shenli shenli added status/LGT2 and removed status/LGT1 labels Mar 4, 2019

@shenli shenli merged commit 3d40d25 into pingcap:release-2.1 Mar 4, 2019

13 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.