Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix false negative "full group by" check for agg in subquery #9542

Merged
merged 1 commit into from Mar 4, 2019

Conversation

Projects
None yet
3 participants
@eurekaka
Copy link
Contributor

eurekaka commented Mar 4, 2019

What problem does this PR solve?

Fix #9518

What is changed and how it works?

Do not recursively dive into subquery in colResolverForOnlyFullGroupBy. Subquery would be checked later in its buildSelect.

Check List

Tests

  • Unit test

Code changes

N/A

Side effects

N/A

Related changes

  • Need to cherry-pick to the release branch
@eurekaka

This comment has been minimized.

Copy link
Contributor Author

eurekaka commented Mar 4, 2019

/run-all-tests

@eurekaka

This comment has been minimized.

Copy link
Contributor Author

eurekaka commented Mar 4, 2019

/run-integration-common-test

@lamxTyler
Copy link
Member

lamxTyler left a comment

LGTM

@zz-jason
Copy link
Member

zz-jason left a comment

LGTM

@zz-jason zz-jason merged commit d81f65f into pingcap:master Mar 4, 2019

13 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@zz-jason zz-jason added status/LGT2 and removed status/LGT1 labels Mar 4, 2019

@eurekaka eurekaka deleted the eurekaka:check_gby branch Mar 5, 2019

ngaut added a commit that referenced this pull request Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.