Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: convert SemiJoin to InnerJoin in more cases #9546

Merged
merged 2 commits into from Mar 5, 2019

Conversation

Projects
None yet
4 participants
@eurekaka
Copy link
Contributor

eurekaka commented Mar 4, 2019

What problem does this PR solve?

Fix #9545

What is changed and how it works?

Even if subquery contains correlated column, we can still convert SemiJoin to InnerJoin if those columns are not correlated with outer children.

Check List

Tests

  • Unit test

Code changes

N/A

Side effects

N/A

Related changes

N/A

planner: convert SemiJoin to InnerJoin in more cases
Even if subquery contains correlated column, we can still convert
SemiJoin to InnerJoin if those columns are not correlated with outer children.
@eurekaka

This comment has been minimized.

Copy link
Contributor Author

eurekaka commented Mar 4, 2019

/run-all-tests

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 5, 2019

Codecov Report

Merging #9546 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9546      +/-   ##
==========================================
+ Coverage   67.37%   67.38%   +<.01%     
==========================================
  Files         375      375              
  Lines       78779    78778       -1     
==========================================
+ Hits        53080    53082       +2     
+ Misses      20928    20925       -3     
  Partials     4771     4771
Impacted Files Coverage Δ
planner/core/logical_plans.go 75.84% <100%> (+2.46%) ⬆️
planner/core/expression_rewriter.go 73.92% <100%> (ø) ⬆️
planner/core/rule_decorrelate.go 90.9% <100%> (-0.96%) ⬇️
planner/core/rule_column_pruning.go 82.21% <100%> (ø) ⬆️
ddl/delete_range.go 75.13% <0%> (-2.65%) ⬇️
executor/join.go 79.58% <0%> (+0.51%) ⬆️
expression/schema.go 94.53% <0%> (+0.78%) ⬆️
ddl/session_pool.go 93.1% <0%> (+10.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d81f65f...caab901. Read the comment docs.

@lamxTyler
Copy link
Member

lamxTyler left a comment

LGTM

@winoros

winoros approved these changes Mar 5, 2019

Copy link
Member

winoros left a comment

lgtm

@winoros winoros merged commit d094a0f into pingcap:master Mar 5, 2019

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@eurekaka eurekaka deleted the eurekaka:semi_to_inner branch Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.