Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: change all the MySQL version from 5.7.10 to 5.7.25 #9553

Merged
merged 6 commits into from Mar 7, 2019

Conversation

Projects
None yet
5 participants
@XuHuaiyu
Copy link
Contributor

XuHuaiyu commented Mar 5, 2019

What problem does this PR solve?

Change all the MySQL version from 5.7.10 to 5.7.25.
related PR: pingcap/parser#231

What is changed and how it works?

N/A

Check List

Tests

  • Manual test
    Start a new tidb-server and connect to it from MySQL-client:
Reading table information for completion of table and column names
You can turn off this feature to get a quicker startup with -A

Welcome to the MySQL monitor.  Commands end with ; or \g.
Your MySQL connection id is 2
Server version: 5.7.25-TiDB-v3.0.0-beta-152-g5ad33c88d-dirty MySQL Community Server
(Apache License 2.0)
...

Code changes

N/A

Side effects

Related changes

N/A

@eurekaka
Copy link
Contributor

eurekaka left a comment

LGTM

@eurekaka eurekaka added the status/LGT1 label Mar 5, 2019

@zz-jason

This comment has been minimized.

Copy link
Member

zz-jason commented Mar 5, 2019

LGTM

Please fix go mod tidy

@XuHuaiyu XuHuaiyu force-pushed the XuHuaiyu:mysql_version branch from 2b31b55 to b57d51f Mar 5, 2019

XuHuaiyu added some commits Mar 5, 2019

@XuHuaiyu XuHuaiyu force-pushed the XuHuaiyu:mysql_version branch from b57d51f to 5d1ded5 Mar 5, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 5, 2019

Codecov Report

Merging #9553 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9553      +/-   ##
==========================================
- Coverage   67.32%   67.31%   -0.02%     
==========================================
  Files         376      376              
  Lines       78967    78967              
==========================================
- Hits        53162    53153       -9     
- Misses      21052    21059       +7     
- Partials     4753     4755       +2
Impacted Files Coverage Δ
store/tikv/2pc.go 77.7% <0%> (-1.77%) ⬇️
executor/join.go 79.06% <0%> (-0.52%) ⬇️
executor/aggregate.go 79.11% <0%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c008460...7536677. Read the comment docs.

@zz-jason zz-jason added status/LGT2 and removed status/LGT1 labels Mar 6, 2019

@jackysp

This comment has been minimized.

Copy link
Member

jackysp commented Mar 6, 2019

/run-all-tests

@jackysp

This comment has been minimized.

Copy link
Member

jackysp commented Mar 6, 2019

This case testInnodbTablespaceEncryption failed in jdbc test.
Because we upgrade the version and this check passed,

if (!versionMeetsMinimum(5, 7, 11)) {
            return;
}

but, TiDB doesn't support

CREATE TABLE testInnodbTablespaceEncryption (id INT) ENCRYPTION='y'

this statement.

@XuHuaiyu

This comment has been minimized.

Copy link
Contributor Author

XuHuaiyu commented Mar 6, 2019

/run-common-test tidb-test=pr/749

XuHuaiyu and others added some commits Mar 7, 2019

@zz-jason

This comment has been minimized.

Copy link
Member

zz-jason commented Mar 7, 2019

/run-all-tests

@zz-jason zz-jason merged commit b3ccefc into pingcap:master Mar 7, 2019

13 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.